Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cholesky of BlockDiagonal(Diagonal) #110

Merged
merged 1 commit into from
Jul 6, 2022
Merged

cholesky of BlockDiagonal(Diagonal) #110

merged 1 commit into from
Jul 6, 2022

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Jul 1, 2022

Closes #109

@mzgubic mzgubic changed the title cholesky of BlockDiagonal(Diagonal) cholesky of BlockDiagonal(Diagonal) Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #110 (7d0225b) into master (5f0dcca) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   96.17%   95.98%   -0.19%     
==========================================
  Files           5        5              
  Lines         340      324      -16     
==========================================
- Hits          327      311      -16     
  Misses         13       13              
Impacted Files Coverage Δ
src/linalg.jl 95.34% <100.00%> (-0.21%) ⬇️
src/blockdiagonal.jl 86.76% <0.00%> (-0.56%) ⬇️
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0dcca...7d0225b. Read the comment docs.

@rofinn rofinn self-requested a review July 5, 2022 19:41
Copy link
Contributor

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Just needs a version bump.

@mzgubic mzgubic merged commit 0a6a7e7 into master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cholesky(BlockDiagonal(Diagonal)) is broken
2 participants