Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle size when blocks is empty #117

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Conversation

mjp98
Copy link
Contributor

@mjp98 mjp98 commented Oct 28, 2022

Related to show error in #30

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #117 (83c183e) into master (932b020) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   96.19%   96.24%   +0.04%     
==========================================
  Files           5        5              
  Lines         342      346       +4     
==========================================
+ Hits          329      333       +4     
  Misses         13       13              
Impacted Files Coverage Δ
src/blockdiagonal.jl 88.00% <100.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a version bump

src/blockdiagonal.jl Show resolved Hide resolved
src/blockdiagonal.jl Outdated Show resolved Hide resolved
mjp98 and others added 2 commits October 28, 2022 12:21
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
@mjp98 mjp98 merged commit 9604a69 into master Oct 31, 2022
@mjp98 mjp98 deleted the mjp/fix-empty-boundscheck branch October 31, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants