Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method ambiguity for * between Adjoint or Transpose and BlockDiagonal with different eltype #122

Merged
merged 7 commits into from
Nov 15, 2022

Conversation

mjp98
Copy link
Contributor

@mjp98 mjp98 commented Nov 4, 2022

closes #91

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #122 (0315d61) into master (86c57e3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files           5        5           
  Lines         358      358           
=======================================
  Hits          354      354           
  Misses          4        4           
Impacted Files Coverage Δ
src/base_maths.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/base_maths.jl Outdated Show resolved Hide resolved
@mjp98 mjp98 requested a review from mzgubic November 14, 2022 14:48
test/base_maths.jl Outdated Show resolved Hide resolved
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
@mjp98 mjp98 merged commit 3ac9c89 into master Nov 15, 2022
@mjp98 mjp98 deleted the mjp/adjoint-ambiguity branch November 15, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method ambiguity between adjoint and BlockDiagonal with different eltype
3 participants