-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3- and 5- argument LinearAlgebra.mul! and copy functions #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 94.9% 95.58% +0.67%
==========================================
Files 4 4
Lines 157 181 +24
==========================================
+ Hits 149 173 +24
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
Please can you post what the current behaviour of mul!
with 3 BlockDiagonal
s is? Does it error, get the wrong results, or is it just not as performant as possible?
If the last one, please can you post some benchmarks indicative of the speed up from the change?
Currently
This is with the current master of BlockDiagonals
This is with the specialized function
|
But I do realize now that maybe the specialized code should fall back to the standard matrix multiplication if the block sizes don't match, but the overall matrix sizes do, instead of throwing an error. |
I implemented the proposed changes. After all, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks a lot.
I bunch of very minor style suggestions.
Please can you bump the version in the Project.toml? Then I will release the new version as soon as this is merged :) Since this is just a performance improvement, and not breaking, we can just bump the last version number. Thanks again!
Co-Authored-By: Nick Robinson <npr251@gmail.com>
No description provided.