Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mistakenly added main dependency on ChainRulesTestUtils #52

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Jan 6, 2021

this is only used for testing

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #52 (dff5831) into master (ebc7050) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           4        4           
  Lines         208      208           
=======================================
  Hits          195      195           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc7050...dff5831. Read the comment docs.

@mjram0s
Copy link
Contributor

mjram0s commented Jan 6, 2021

Do we want to leave the compat entry?

@oxinabox
Copy link
Member Author

oxinabox commented Jan 6, 2021

Do we want to leave the compat entry?

Yes, it is still binding on the test dependency

@oxinabox oxinabox merged commit 089ae3a into master Jan 6, 2021
@mjram0s mjram0s mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants