Disambiguate (::ProjectTo) #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 96.09% 95.89% -0.20%
==========================================
Files 5 5
Lines 333 317 -16
==========================================
- Hits 320 304 -16
Misses 13 13
Continue to review full report at Codecov.
|
|
@platawiec thanks for this. Could you please bump the patch version? I'm happy to approve + release once that's done. |
platawiec
force-pushed
the
projectto-disambiguate
branch
from
0b0efab
to
15a145c
Compare
willtebbutt
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #84 by slightly restricting the type signature of
(::ProjectTo{BlockDiagonal})(dx)to(::ProjectTo{BlockDiagonal})(dx::AbstractArray). This follows the pattern established in ChainRulesCore'sProjectTodefinitions for linear algebra.