Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly state that non-square blocks are allowed #99

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented May 17, 2022

closes #98

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #99 (2725f0d) into master (0de657d) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   96.11%   95.92%   -0.20%     
==========================================
  Files           5        5              
  Lines         335      319      -16     
==========================================
- Hits          322      306      -16     
  Misses         13       13              
Impacted Files Coverage Δ
src/blockdiagonal.jl 85.71% <0.00%> (-0.65%) ⬇️
src/linalg.jl 95.34% <0.00%> (-0.21%) ⬇️
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de657d...2725f0d. Read the comment docs.

@mzgubic mzgubic merged commit fc727ab into master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention that non-square blocks are allowed in the documentation
2 participants