Merge pull request #10 from JuliaArrays/massinstallaction/set-up-CI

Switch to GitHub Actions for CI, fix an ambiguity

.github/workflows/CI.yml

@@ -0,0 +1,47 @@
+name: CI
+on:
+  pull_request:
+  push:
+    branches:
+      - master
+    tags: '*'
+jobs:
+  test:
+    name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        version:
+          - '0.7'
+          - '1.0'
+          - '1'
+#          - 'nightly'
+        os:
+          - ubuntu-latest
+          - macOS-latest
+          - windows-latest
+        arch:
+          - x64
+    steps:
+      - uses: actions/checkout@v2
+      - uses: julia-actions/setup-julia@v1
+        with:
+          version: ${{ matrix.version }}
+          arch: ${{ matrix.arch }}
+      - uses: actions/cache@v1
+        env:
+          cache-name: cache-artifacts
+        with:
+          path: ~/.julia/artifacts
+          key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
+          restore-keys: |
+            ${{ runner.os }}-test-${{ env.cache-name }}-
+            ${{ runner.os }}-test-
+            ${{ runner.os }}-
+      - uses: julia-actions/julia-buildpkg@v1
+      - uses: julia-actions/julia-runtest@v1
+      - uses: julia-actions/julia-processcoverage@v1
+      - uses: codecov/codecov-action@v1
+        with:
+          file: lcov.info

src/bidirectional.jl

@@ -25,16 +25,16 @@ Base.axes( v::BidirectionalVector) = (Base.axes1(v),)
 Base.size( v::BidirectionalVector) = (length(v),)
 Base.length(v::BidirectionalVector) = length(v.data)
 
-function Base.similar(v::AbstractArray, T::Type, inds::Tuple{URange})
+function Base.similar(::AbstractArray, ::Type{T}, inds::Tuple{URange}) where T
     inds1 = inds[1]
     n = length(inds1)
     BidirectionalVector(Array{T}(undef, n), first(inds1)-1)
 end
 
-function Base.similar(f::Union{Function,Type}, inds::Tuple{URange})
+function Base.similar(::Type{T}, inds::Tuple{URange}) where T<:AbstractArray
     inds1 = inds[1]
     n = length(inds1)
-    BidirectionalVector(f(Base.OneTo(n)), first(inds1)-1)
+    BidirectionalVector(T(Base.OneTo(n)), first(inds1)-1)
 end
 
 @inline function Base.getindex(v::BidirectionalVector, i::Int)

test/runtests.jl

@@ -3,6 +3,9 @@ using Test
 
 ### BidirectionalVector
 @testset "CatIndices" begin
+    if Base.VERSION >= v"1.6.0-DEV.1005"
+        @test isempty(detect_ambiguities(CatIndices))
+    end
     function checkvals(v)
         for i in axes(v,1)
             @test v[i] == i