Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findfirst for InfStepRange for negative step #192

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 27, 2024

Fixes #180

After this,

julia> findfirst(==(9), 10:-1:-∞)
2

julia> findfirst(==(11), 10:-1:-∞)

julia> findfirst(==(21), 10:-1:-∞)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (8865985) to head (227ef65).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   85.49%   86.14%   +0.65%     
==========================================
  Files           7        6       -1     
  Lines         772      758      -14     
==========================================
- Hits          660      653       -7     
+ Misses        112      105       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub force-pushed the jishnub/infsteprange_findfirst branch from eb992be to 3d04014 Compare August 27, 2024 10:03
@jishnub jishnub merged commit 847dca1 into master Aug 27, 2024
12 checks passed
@jishnub jishnub deleted the jishnub/infsteprange_findfirst branch August 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findfirst doesn't work for infranges with negative step sizes
1 participant