Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround type inference issue on Julia master #139

Closed
wants to merge 3 commits into from

Conversation

jipolanco
Copy link
Contributor

Fixes #138

@dlfivefifty
Copy link
Member

dlfivefifty commented Oct 21, 2020

Thanks! Do you know why this regression happened? Maybe we should file an issue on JuliaLang/julia if it can be reproduced on a simpler example?

@jipolanco
Copy link
Contributor Author

You're right, it may be a regression in base Julia. I'll see if I can reproduce a minimal example and file an issue.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #139 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   87.46%   87.40%   -0.07%     
==========================================
  Files          12       12              
  Lines        1540     1540              
==========================================
- Hits         1347     1346       -1     
- Misses        193      194       +1     
Impacted Files Coverage Δ
src/lazyconcat.jl 93.81% <100.00%> (ø)
src/lazyoperations.jl 86.72% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fd0ca...4ecfb92. Read the comment docs.

@jipolanco
Copy link
Contributor Author

Closing this because inference regression was fixed on Julia master.

@jipolanco jipolanco closed this Dec 12, 2020
@jipolanco jipolanco deleted the jip/concat_inference branch January 9, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inference issues on Julia master (v1.6)
2 participants