Fixes for Julia 0.6 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #20. Might be cleaner to take that one for the |
|
I missed that you already had something here. You can bring the change in #20 if you want and I'll close that one. |
|
No, I like this a little better. Let's merge it. |
|
Rebased. |
|
I don't see any need to wait for resolution on JuliaLang/julia#20573, so I'll merge and tag a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some deprecation warnings (generated by the tests, not the code in
src). This requires JuliaLang/julia#20573 to pass tests on 0.6, but makes sense even without it.