Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update in anticipation of deprecating similar(f, ...) #43

Merged
merged 2 commits into from
Jun 6, 2018
Merged

Update in anticipation of deprecating similar(f, ...) #43

merged 2 commits into from
Jun 6, 2018

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Apr 6, 2018

Requires JuliaLang/julia#26733.

This removes the methods dispatching on similar(f::Function) in favor of just adding methods to f directly.

@mbauman mbauman mentioned this pull request Apr 6, 2018
Merged
@mbauman mbauman force-pushed the mb/26733-deprecatesimilarf branch from ee066b2 to 857e821 Compare May 9, 2018 23:01
@mbauman
Copy link
Member Author

mbauman commented May 9, 2018

Ah, of course — I'll need to do some Compat work here for 0.6.

@mbauman
Copy link
Member Author

mbauman commented Jun 6, 2018

Now tests pass on 0.6, but fail on Nightly due to the lack of #46. I'm going to merge this and see what we can do about compatibility with the new axis setup in #46.

@mbauman mbauman merged commit 2be1cff into JuliaArrays:master Jun 6, 2018
@mbauman mbauman deleted the mb/26733-deprecatesimilarf branch June 6, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbauman