remove stale broadcasted_indices
#1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is having a hard time with some internal out-of-memory errors. Shouldn't be related to this though (but somewhat annoying; same sporadic failures for CI restarted 3 times). |
- referenced non-extant `indices` - `broadcasted_indices` was deprecated to `broadcasted_axes` in JuliaLang/julia#25377 - `broadcasted_axes` was then replaced by plain `axes` JuliaLang/julia@a2feccf - StaticArrays already has `axes` methods
mateuszbaran
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor nit found while playing around with JET.jl's
report_package(the other highlights from that appeared to be false positives as far as I could see, so that's nice).Justification is in the commit message.