Make Array-of-SArray op Number infer the right output Array type
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, there's special rules using Base.promote_op to infer the correct type for operations involving Number and arrays of other types. This means we need to overload promote_op or we'll get an Array of Any in these cases.
c42f
force-pushed
the
arrays-of-sarrays
branch
from
ce03a47
to
05be4fb
Compare
|
Changes Unknown when pulling 05be4fb on arrays-of-sarrays into * on master*. |
|
Changes Unknown when pulling 05be4fb on arrays-of-sarrays into * on master*. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, there's special rules using Base.promote_op to infer
the correct type for operations involving Number and arrays of other
types. This means we need to overload promote_op or we'll get an Array
of Any in these cases.
See SimonDanisch/FixedSizeArrays.jl#156 for a similar issue.