Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the things #503

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Fix all the things #503

merged 1 commit into from
Sep 20, 2018

Conversation

andyferris
Copy link
Member

Solve various inference issues. Replaces #495 and #330.
Closes #493.

Note: the eltype of empty arrays may become Union{} in
map, broadcast, and mapreduce(...; dims = Val{N}).

@andyferris
Copy link
Member Author

Since there seems to be little enough harm in Union{} eltypes for statically sized arrays that have passed through map or broadcast, and that lets us remove all references to inference, I decided to try that for now.

Solve various inference issues. Replaces #495 and #330.
Closes #493.

Note: the eltype of empty arrays may become `Union{}` in
`map`, `broadcast`, and `mapreduce(...; dims = Val{N})`.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 94.985% when pulling 03165ba on ajf/noinference into 81dd6ca on master.

@andyferris
Copy link
Member Author

I will go ahead and merge this. Please comment here or open issues with whatever the fallout is :)

@andyferris andyferris merged commit 8609799 into master Sep 20, 2018
@andyferris andyferris deleted the ajf/noinference branch September 20, 2018 09:51
@c42f
Copy link
Member

c42f commented Sep 20, 2018

Wow great to see all the things fixed! Time to close all the those tiresome issues and release version 1.0.0 :-)

@andyferris
Copy link
Member Author

Lol.

By the time I was done, it seemed to annoying to enumerate all the little things... :)

But actually yes, I would like to release v1.0 soon. (I think we should deprecate FixedSizeArrays and Immutable arrays first, though).

@c42f
Copy link
Member

c42f commented Sep 21, 2018

Agreed, those old interfaces should go. If there's any remaining difference in functionality we should subsume that and move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants