-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MScalar Type #591
Add MScalar Type #591
Conversation
fixed bugs with zero-dimensional MArray getindex.
This appears to introduce an ambiguity on 1.0.3. Do you still care about this? |
Also worth pointing out #518 |
While I think these changes might provide some nice symmetry with the "Scalar" type, I mostly wanted to fix indexing for zero-dimensional MArrays, which I think happened in #581. |
I suppose we could add this, for symmetry as noted. On the other hand, many use cases are well covered by (On a side note, I'm still curious whether something will shake out of the references work (that Keno is interested in) that covers the broadcast-as-a-scalar case, too) |
I think we should close this and direct people to use |
Yes, it's tempting to do as Chris says and just leave this. (I always hoped for an alias to appear in |
Ok, I'll close this for now. However, if you do find a need for |
Why not also have an MScalar type? This also includes the zero dimensional broadcast fix from pja/zero-dim-broadcast. Perhaps this would help with #580?