Remove show(::IO, ::Type{StaticArrays.Blah}) overloads #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently these can be problematic for compiler-internal reasons, and I think the printing has been improved such that the remaining cases of these may not do anything useful. So let's just remove them.
c42f
force-pushed
the
cjf/remove-show-Type
branch
from
71cf83c to
00a6198
Compare
|
By the way, I'd say exactly why removing these is a good idea if I understood it! All I really know is that some obscure and very nasty Pumas.jl issue may have been related to the presence of these methods. And that removing them would do no real harm. CC @andreasnoack |
|
See also PainterQubits/Unitful.jl#321 |
|
Old history here: JuliaLang/julia#13306. Not sure how much of a modern problem it is, but I've been paranoid about specializing |
ararslan
approved these changes
Apr 22, 2020
|
Thanks for chiming in here with the links! I only had a very vague memory of some of those past issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently these can be problematic for compiler-internal reasons, and I
think the printing has been improved such that the remaining cases of
these may not do anything useful. So let's just remove them.