Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reduction over empty array #780

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix reduction over empty array #780

merged 1 commit into from
May 3, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented May 2, 2020

fix #778

@tkf tkf mentioned this pull request May 2, 2020
Closed
c42f
c42f approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks so much for digging into this!

@tkf tkf merged commit 32a7ed8 into JuliaArrays:master May 3, 2020
@tkf tkf deleted the fix-empty branch May 3, 2020 02:29
@c42f c42f added the bugfix label May 3, 2020
@pablosanjose pablosanjose mentioned this pull request May 3, 2020
Closed
@tkf tkf mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c42f c42f c42f approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iszero(::SVector{0}) broken
2 participants
@tkf @c42f