Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Size here? #12

Closed
devmotion opened this issue Sep 18, 2022 · 1 comment · Fixed by #13
Closed

Move Size here? #12

devmotion opened this issue Sep 18, 2022 · 1 comment · Fixed by #13

Comments

@devmotion
Copy link

devmotion commented Sep 18, 2022 •
edited
Loading

I wonder if it would be possible to move Size to this package? For instance, by moving (parts of) https://github.com/JuliaArrays/StaticArrays.jl/blob/ec2dc5ee8559e4d3125e4a392c050bfa27b8bfe1/src/traits.jl?

This was already discussed briefly in #3.
Size is currently mentioned in the docstring of similar_type even though it is not available in StaticArraysCore.
If it would be available also downstream code such as in JuliaDiff/DiffResults.jl#22 could be simplified.
@devmotion devmotion mentioned this issue Sep 18, 2022
Merged
@mateuszbaran
Copy link
Collaborator

Yes, I think that would be a good idea. I will try doing it today or tomorrow.

@mateuszbaran mateuszbaran mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Size from StaticArrays.jl JuliaArrays/StaticArraysCore.jl
2 participants
@devmotion @mateuszbaran