Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Size from StaticArrays.jl #13

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Move Size from StaticArrays.jl #13

merged 3 commits into from
Sep 21, 2022

Conversation

mateuszbaran
Copy link
Collaborator

Resolves #12 .

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #13 (7810953) into main (d8a087f) will decrease coverage by 1.61%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##              main      #13      +/-   ##
===========================================
- Coverage   100.00%   98.38%   -1.62%     
===========================================
  Files            1        1              
  Lines           48       62      +14     
===========================================
+ Hits            48       61      +13     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/StaticArraysCore.jl 98.38% <92.85%> (-1.62%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thchr
Copy link
Collaborator

thchr commented Sep 20, 2022

Should Size be exported? It is by StaticArrays.

@mateuszbaran
Copy link
Collaborator Author

Good point, it probably should.

@mateuszbaran
Copy link
Collaborator Author

The one missing line of coverage looks to me like a false positive so I'm going to merge this PR soon.

@mateuszbaran mateuszbaran merged commit 33f4dad into main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Size here?
2 participants