-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp conversions and use instances instead of types as parameters #16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 97.28% 97.41% +0.12%
==========================================
Files 6 6
Lines 295 271 -24
==========================================
- Hits 287 264 -23
+ Misses 8 7 -1
Continue to review full report at Codecov.
|
I want to make one more change and add the argument for the conversion function, e.g. @transform TAI UTC ep begin
jd1, jd2 = julian1(ep), julian2(ep)
date, date1 = ERFA.taiutc(jd1, jd2)
UTCEpoch(date, date1)
end Makes it a bit less magical and you do not need to memorize what arguments the resulting function will accept. |
This needs JuliaLang/METADATA.jl#13963
Once I have documented the
@transform
macro the package should (finally) be ready for publication 🎉