Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp conversions and use instances instead of types as parameters #16

Merged
merged 13 commits into from
Apr 4, 2018

Conversation

helgee
Copy link
Member

@helgee helgee commented Mar 24, 2018

This needs JuliaLang/METADATA.jl#13963

Once I have documented the @transform macro the package should (finally) be ready for publication 🎉

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #16 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   97.28%   97.41%   +0.12%     
==========================================
  Files           6        6              
  Lines         295      271      -24     
==========================================
- Hits          287      264      -23     
+ Misses          8        7       -1
Impacted Files Coverage Δ
src/AstronomicalTime.jl 100% <ø> (ø) ⬆️
src/TimeScales.jl 100% <100%> (ø) ⬆️
src/conversions.jl 100% <100%> (+0.56%) ⬆️
src/Epochs.jl 97.14% <100%> (-0.23%) ⬇️
src/Periods.jl 86.95% <0%> (-1.51%) ⬇️
src/LeapSeconds.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe85130...5768ba0. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage increased (+0.1%) to 97.417% when pulling 5768ba0 on transform into fe85130 on master.

@helgee
Copy link
Member Author

helgee commented Mar 28, 2018

I want to make one more change and add the argument for the conversion function, e.g. ep, as a parameter for the macro:

@transform TAI UTC ep begin
     jd1, jd2 = julian1(ep), julian2(ep)
     date, date1 = ERFA.taiutc(jd1, jd2)
     UTCEpoch(date, date1)
 end

Makes it a bit less magical and you do not need to memorize what arguments the resulting function will accept.

@helgee helgee merged commit 7d56ec0 into master Apr 4, 2018
@helgee helgee deleted the transform branch April 4, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants