-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added F04 model #31
Added F04 model #31
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 99.45% 99.48% +0.03%
==========================================
Files 4 4
Lines 182 195 +13
==========================================
+ Hits 181 194 +13
Misses 1 1
Continue to review full report at Codecov.
|
Could you please leave a comment in the code so that when we'll drop support for Julia v1.0 we can remove this workaround? |
Sure, just added! 1f6fae8 haha, it's kind of wild to think about leaving 1.0 behind some day ='( |
Not really, there is the general hope of making Julia v1.6 the new Long Term Support version (but the decision will be taken after its release), at which point Julia v1.0 will not be supported anymore 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, if you bump version to 0.9.0, too we can release.
https://dust-extinction.readthedocs.io/en/stable/api/dust_extinction.parameter_averages.F04.html?highlight=F04
Contributing to #10