Add ModelingToolkit.jl extension #16

langestefan · 2025-11-20T23:42:33Z

This will add an extension for ModelingToolkit.jl to enable creation of solar position modeling blocks that can be plugged into any symbolic model.

Copilot

Pull Request Overview

This PR adds a ModelingToolkit.jl extension to SolarPosition.jl, enabling integration of solar position calculations into symbolic modeling workflows for applications like solar energy modeling, building thermal analysis, and solar tracking systems.

Key changes:

Created SolarPositionModelingToolkitExt extension that provides a SolarPositionBlock component for computing solar azimuth, elevation, and zenith angles as time-varying symbolic variables
Added comprehensive tests demonstrating component creation, composition with other systems, and ODE solving
Added documentation with examples showing integration with solar panel and building thermal models

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`ext/SolarPositionModelingToolkitExt.jl`	Implements the ModelingToolkit extension with `SolarPositionBlock` component and symbolic function registration
`src/SolarPosition.jl`	Exports new types and adds comprehensive docstring for `SolarPositionBlock`
`src/Positioning/Positioning.jl`	Introduces `AbstractApparentSolPos` type hierarchy for better type organization
`test/test-mtk.jl`	Adds tests for block creation, composition, and ODE solving with plotting validation
`test/runtests.jl`	Comments out previous imports (follows existing pattern for auto-discovery)
`test/Project.toml`	Adds test dependencies for ModelingToolkit, OrdinaryDiffEq, and CairoMakie
`docs/src/examples/modelingtoolkit.md`	Comprehensive guide with examples of solar panel and building thermal models
`docs/src/index.md`	Documents the new ModelingToolkit extension in the main index
`docs/make.jl`	Adds modelingtoolkit.md to documentation build
`docs/Project.toml`	Adds ModelingToolkit and OrdinaryDiffEq for documentation builds
`examples/mtk-integration.jl`	Commented example code demonstrating various use cases
`examples/Project.toml`	Declares dependencies for examples
`Project.toml`	Adds ModelingToolkit and Symbolics as weak dependencies with compat entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/test-mtk.jl

examples/mtk-integration.jl

test/test-mtk.jl

codecov · 2025-11-21T00:10:08Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.74%. Comparing base (4a17e29) to head (5e1824b).
⚠️ Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Positioning/spa.jl	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   92.36%   92.74%   +0.37%     
==========================================
  Files          15       15              
  Lines         511      510       -1     
==========================================
+ Hits          472      473       +1     
+ Misses         39       37       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

langestefan · 2025-11-22T15:13:21Z

@copilot run Julia formatter to pass linting CI

Copilot · 2025-11-22T15:13:29Z

@langestefan I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: langestefan <37669773+langestefan@users.noreply.github.com>

Run Julia formatter to fix linting CI

Copilot

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 9 comments.

test/test-mtk.jl

src/Positioning/Positioning.jl

ext/SolarPositionModelingToolkitExt.jl

src/Positioning/Positioning.jl

src/Positioning/spa.jl

ext/SolarPositionModelingToolkitExt.jl

docs/src/examples/modelingtoolkit.md

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

Copilot · 2025-11-23T20:35:13Z

src/SolarPosition.jl

+```julia
+using SolarPosition, ModelingToolkit
+using ModelingToolkit: t_nounits as t
+using Dates
+
+@named sun = SolarPositionBlock()
+obs = Observer(51.5, -0.18, 15.0)
+t0 = DateTime(2024, 6, 21, 12, 0, 0)
+
+sys = mtkcompile(sun)
+pmap = [
+    sys.observer => obs,
+    sys.t0 => t0,
+    sys.algorithm => PSA(),
+    sys.refraction => NoRefraction(),
+]
+
+prob = ODEProblem(sys, pmap, (0.0, 86400.0))
+sol = solve(prob; saveat = 3600.0)
+```


The example code is incomplete and missing required imports. The code uses @named (line 86) and mtkcompile (line 90) from ModelingToolkit, and ODEProblem and solve (lines 98-99) from OrdinaryDiffEq, but these are not imported. Add the following imports to make the example self-contained:

using SolarPosition, ModelingToolkit using ModelingToolkit: t_nounits as t, @named, mtkcompile using Dates using OrdinaryDiffEq: ODEProblem, solve

ext/SolarPositionModelingToolkitExt.jl

Copilot · 2025-11-23T20:35:14Z

test/test-mtk.jl

+using ModelingToolkit: t_nounits as t, D_nounits as D
+using Dates: DateTime
+using OrdinaryDiffEq
+using CairoMakie


Missing import for TimeZones functions. The test uses astimezone (line 183) and tz"UTC" (line 183) from TimeZones package but doesn't import TimeZones. Add using TimeZones: astimezone, @tz_str at the top of this file.

Suggested change

using CairoMakie

using CairoMakie

using TimeZones: astimezone, @tz_str

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

langestefan added 3 commits November 11, 2025 23:23

Initial version of MTK extension

8848b06

Update imports in MTK extension

d2e25e4

Add docs for ModelingToolkit.jl extension

8ac601e

langestefan requested a review from Copilot November 20, 2025 23:42

langestefan marked this pull request as draft November 20, 2025 23:46

Copilot started reviewing on behalf of langestefan November 20, 2025 23:56 View session

Copilot finished reviewing on behalf of langestefan November 20, 2025 23:58

Copilot AI reviewed Nov 20, 2025

View reviewed changes

test/test-mtk.jl Outdated Show resolved Hide resolved

examples/mtk-integration.jl Outdated Show resolved Hide resolved

examples/mtk-integration.jl Outdated Show resolved Hide resolved

test/test-mtk.jl Outdated Show resolved Hide resolved

langestefan and others added 4 commits November 21, 2025 14:35

Update test/test-mtk.jl

38110dc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update examples/mtk-integration.jl

0d35620

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update examples/mtk-integration.jl

2353a39

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/test-mtk.jl

4fa1382

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

6225851

Copilot AI mentioned this pull request Nov 22, 2025

Run Julia formatter to fix linting CI #17

Merged

4 tasks

Copilot AI and others added 4 commits November 22, 2025 15:17

Run Julia formatter to fix linting

4acb563

Co-authored-by: langestefan <37669773+langestefan@users.noreply.github.com>

Merge pull request #17 from JuliaAstro/copilot/sub-pr-16

4d0722c

Run Julia formatter to fix linting CI

Add apparent position to MTK component and validate positions

b1b00a3

Add maxlog = 1 to @warn

b3e4ba6

langestefan requested a review from Copilot November 23, 2025 19:06

Copilot started reviewing on behalf of langestefan November 23, 2025 19:07 View session

Copilot finished reviewing on behalf of langestefan November 23, 2025 19:11

Copilot AI reviewed Nov 23, 2025

View reviewed changes

langestefan added 5 commits November 23, 2025 20:43

Put all expected values in expected-values.jl

b580e18

Fix typo

2cbc6b2

Use abstract solpos types in MTK ext

d0ccd85

Remove whitespace

2d8ce0f

Remove unecessary enumerate

d001a0c

langestefan marked this pull request as ready for review November 23, 2025 20:13

langestefan requested a review from Copilot November 23, 2025 20:13

Copilot started reviewing on behalf of langestefan November 23, 2025 20:30 View session

Copilot finished reviewing on behalf of langestefan November 23, 2025 20:34

Copilot AI reviewed Nov 23, 2025

View reviewed changes

langestefan and others added 2 commits November 23, 2025 21:44

Update ext/SolarPositionModelingToolkitExt.jl

35877b1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Cleanup

5e1824b

langestefan merged commit 7a4cb78 into main Nov 23, 2025
13 of 14 checks passed

langestefan deleted the mtk-extension branch November 23, 2025 23:00

	using CairoMakie
	using CairoMakie
	using TimeZones: astimezone, @tz_str

Add ModelingToolkit.jl extension #16

Add ModelingToolkit.jl extension #16

Uh oh!

Conversation

langestefan commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

langestefan commented Nov 22, 2025

Uh oh!

Copilot AI commented Nov 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Nov 21, 2025 •

edited

Loading