Elehcim gadget2 particle #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Many routines translated from pynbody to read gadget2 files (format 1 and 2). - Drastically reduced code repetition. TODO: - A config file needed for collect gadget user defined fields and relative units. - StructArray data type (e.g. Float32 of Float64) can't be instantiated at runtime. I think it should be possible, but still I need to find a way. - Rebase with latest modifications upstream
More elegant way, not having to append! (which was causing a 'type does not have a definite number of fields' error). Also probably more efficient because memory is contiguous from the beginning.
because there is no method for
`peek(::Stream{DataFormat{:Gadget2}, args...)`
… into elehcim-Gadget2Particle
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 70.13% 74.14% +4.01%
==========================================
Files 8 9 +1
Lines 673 704 +31
==========================================
+ Hits 472 522 +50
+ Misses 201 182 -19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.