Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#58 - Added TestSuiteResultsWriter with exported write function … #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

passionateprogrammersguild

…as a way to override how the results are output. Also made an allowance for the filename to be passed into the facts function, and updated the examples.jl with supporting examples

…as a way to override how the results are output. Also made an allowance for the filename to be passed into the facts function, and updated the examples.jl with supporting examples
end

function FactCheck.write(dummyWriter::DummyWriter, io::IO, suite::TestSuite)
n_succ = length(suite.successes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things should be removed as they are not used. I will remove them

@IainNZ
Copy link
Contributor

IainNZ commented Sep 9, 2015

How has the worked out for you locally? Were you able to implement your custom writer?

@passionateprogrammersguild
Copy link
Author

Funny you mention that, I got pulled off onto something else. If I demonstrate a custom writer that fits our needs would that help move this forward in proving the concept out? If so I will certainly implement a NunitOutputWriter and send you the code.

That exercise would be a lot of fun actually.

Blessings
Michael

@IainNZ
Copy link
Contributor

IainNZ commented Sep 9, 2015

Its just that I'm busy too, and working on a lot of other stuff (like my day job!).
So while this looks sensible, it adds complexity, so it'd be good to know its needed and has been tested in real life settings.

@passionateprogrammersguild
Copy link
Author

I totally get it and understand. I will work on the NUnit renderer and will either send you sample code or I can add it to a samples folder for reference in the next pull request.

Thanks,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants