Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Examples #107

wants to merge 4 commits into from

Conversation

bramtayl
Copy link
Member

@JeffFessler this is what I have so far

@bramtayl
Copy link
Member Author

Just the second commit actually oops

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #107 (d90a483) into master (44d4ca3) will decrease coverage by 74.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #107       +/-   ##
===========================================
- Coverage   97.42%   23.12%   -74.31%     
===========================================
  Files           2        2               
  Lines         350      333       -17     
===========================================
- Hits          341       77      -264     
- Misses          9      256      +247     
Impacted Files Coverage Δ
src/PortAudio.jl 18.63% <0.00%> (-78.84%) ⬇️
src/libportaudio.jl 40.00% <0.00%> (-57.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d4ca3...d90a483. Read the comment docs.

@JeffFessler JeffFessler mentioned this pull request Feb 14, 2022
@bramtayl
Copy link
Member Author

bramtayl commented Mar 4, 2022

@ssfrr Ok, I give, I can't get the makie examples to run. I think you wrote them; can you help?

@ssfrr
Copy link
Contributor

ssfrr commented Mar 4, 2022

Can you be more specific about what isn’t working? Makie has changed a lot since this was written so I wouldn’t be surprised if all the makie stuff has to be basically rewritten from scratch

@bramtayl
Copy link
Member Author

bramtayl commented Mar 4, 2022

Well, one change I had to make to this and the other examples is to run them only for a certain amount of time. So I replaced the while isopen(scene[:screen]) block with something like

done = false
@sync begin
    @async while !done
        # do stuff
    end
    sleep(seconds)
    done = true
end

It doesn't help that I don't really understand FFT. I can paste the errors I get from running what I have if that would be helpful.

@JeffFessler
Copy link
Member

Would it make sense to separate the Makie-related changes from the rest so that at least the rest of the examples could be updated, and then return to the Makie ones later when someone with Makie expertise has time for them?

@bramtayl
Copy link
Member Author

Sure, we can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants