add miscellaneous benchmarks from various issues #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jrevels
reviewed
Oct 18, 2016
| return s | ||
| end | ||
|
|
||
| g[(3,3,3)] = @benchmarkable perf_splatting($(samerand(3,3,3)), 1000000, 1, 2, 3) |
There was a problem hiding this comment.
Can we decrease the 1000000 here to 100 for the sake of efficiency (i.e. more samples per second)?
jrevels
reviewed
Oct 18, 2016
| g = addgroup!(SUITE, "afoldl", ["+", "getindex"]) | ||
| g["Int"] = @benchmarkable perf_afoldl(1000000, $(zeros(Int, 20))) | ||
| g["Float64"] = @benchmarkable perf_afoldl(1000000, $(zeros(Float64, 20))) | ||
| g["Complex{Float64}"] = @benchmarkable perf_afoldl(1000000, $(zeros(Complex{Float64}, 20))) |
There was a problem hiding this comment.
These can also go from 1000000 to 100.
|
Okay, reduced the sample sizes. |
jrevels
reviewed
Oct 18, 2016
| end | ||
|
|
||
| g = addgroup!(SUITE, "parse", ["DateTime"]) | ||
| datestr = map(string,range(DateTime("2016-02-19T12:34:56"),Dates.Millisecond(123),10_000)) |
There was a problem hiding this comment.
This one should be dialed down as well (from 10_000 to 100 should be fine). If you're curious about the scale I'm using, the main idea is to keep most benchmarks from going over ~1ms/evaluation when possible (enabling us to gather on the order of hundreds of samples per benchmark).
|
Thanks, LGTM. Merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds benchmarks based on JuliaLang/julia#13359 (cc @timholy), JuliaLang/julia#13724, JuliaLang/julia#15553, JuliaLang/julia#18135, and JuliaLang/julia#18000.
I also created a "miscellaneous" benchmark suite to stick these into. The code can always be refactored later into different categories, but it is good to have a place to quickly add new benchmarks that don't clearly fit into one of the existing suites.