Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong missing lines #132

Closed
atbug opened this issue Aug 19, 2017 · 6 comments
Closed

Wrong missing lines #132

atbug opened this issue Aug 19, 2017 · 6 comments

Comments

@atbug
Copy link

atbug commented Aug 19, 2017

Using Coverage.jl, my repository has some false missing lines such as end and comments.

see https://codecov.io/gh/mistguy/Hop.jl/src/8f204ade24270ee1b32a794a94b2078b35cb9a97/src/Hop.jl

@atbug
Copy link
Author

atbug commented Aug 23, 2017

Related: https://discourse.julialang.org/t/is-there-a-problem-with-codecov-and-nightly/5517
It seems to be nightly related issue.

@bramtayl
Copy link

bramtayl commented Sep 4, 2017

Anyone have any breadcrumbs? Causing me some issues and I'd be happy to take a stab if I knew where to start

@fjarri
Copy link

fjarri commented Sep 4, 2017

For what it's worth, here are my observations:

  • Coveralls still displays the coverage correctly, the problem only appears with Codecov
  • When my package is tested on Travis, the first platforms to finish are v0.6 Mac and Linux; after they submit their results, Codecov displays the correct (high) coverage. When the first nightly result comes in (usually from Linux, but I don't think it's important) and is incorporated, the displayed coverage suddenly drops 30%.

The last one is especially strange, since I assumed that coverage results are joined, so if you have X% coverage on one platform, you will have at least X% coverage in total.

@iamed2
Copy link
Member

iamed2 commented Sep 4, 2017

The last one is especially strange, since I assumed that coverage results are joined, so if you have X% coverage on one platform, you will have at least X% coverage in total.

My guess is that the nightly version is adding (uncovered) code lines which weren't marked as code lines in the previous versions.

@fingolfin
Copy link
Member

I just had a look at https://codecov.io/gh/mistguy/Hop.jl/src/master/src/Hop.jl and could not see any end statements that were "red", so I am assuming this issue has been resolved in the meantime. If not, feel free to reopen and provide additional details. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants