Fix tests on Julia v0.7 #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
===========================================
- Coverage 73.02% 52.04% -20.99%
===========================================
Files 6 6
Lines 241 342 +101
===========================================
+ Hits 176 178 +2
- Misses 65 164 +99
Continue to review full report at Codecov.
|
test/runtests.jl
Outdated
| # In v0.6, the zero count goes to line 10, and in v0.7, the zero count goes (more correctly?) | ||
| # to line 11 | ||
|
|
||
| if VERSION < v"0.7.0-" |
There was a problem hiding this comment.
any idea more specifically what caused the change? looks like it happened between 2 and 3 months ago, judging by travis logs - https://travis-ci.org/JuliaCI/Coverage.jl/builds/234799535 vs https://travis-ci.org/JuliaCI/Coverage.jl/builds/248594841
There was a problem hiding this comment.
I don't have time to test or do a proper git bisect right now, but https://github.com/JuliaLang/julia/pull/21746/commits is one possiblilty.
There was a problem hiding this comment.
But I'm somewhat doubtful, so we'll probably need to do a git bisect to find out the true cause.
My real interest here is to attempt to discover why coverage is dropping significantly for most projects (such as the codecov/project below--see #132). I'm not even sure this is related, so might want to do a git bisect for this as well, if possible.
There was a problem hiding this comment.
Running git bisect now.
There was a problem hiding this comment.
git bisect says the culprit is "various improvements to parser #22161", which makes much more sense than my initial guess.
I've updated the pull request to reference this specific commit. Not sure right now if it has anything to do with #132, although it's probably worth testing.
* JuliaLang/julia#22161 updated the parser and caused some changes in how Coverage works * For test/data/testparser.jl, line 10 is the end of a @doc string (`""" ->`), and Line 11 is an expression (`f6(x) = 6x`) * Before the above commit, the zero count goes to line 10, and after, the zero count goes (more correctly?) to line 11
kmsquire
force-pushed
the
kms/fix_v0.7_coverage_bug
branch
from
7fce1b9 to
000e914
Compare
For test/data/testparser.jl, line 10 is the end of a @doc string (
""" ->), and Line 11is an expression (
f6(x) = 6x)to line 11