Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documenter key and warning about SSH setup #460

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add Documenter key and warning about SSH setup #460

merged 1 commit into from
Feb 9, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Feb 9, 2024

Fix #459

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f6c392) 94.33% compared to head (34f4eea) 94.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          24       24           
  Lines         742      742           
=======================================
  Hits          700      700           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could automate this step

@gdalle
Copy link
Collaborator Author

gdalle commented Feb 9, 2024

Me too, but I'm not sure we can fiddle with the GitHub API, especially with secret SSH keys, and live to tell the tale

@gdalle gdalle changed the title Add Documenter key and warinng about SSH setup Add Documenter key and warning about SSH setup Feb 9, 2024
@gdalle gdalle merged commit a775fe5 into master Feb 9, 2024
17 checks passed
@gdalle gdalle deleted the gd/dockey branch February 9, 2024 12:30
@adrhill
Copy link

adrhill commented Feb 9, 2024

I wish we could automate this step

Maybe a solution between just having a note in the docstring and calling the GitHub API would be to print the output of DocumenterTools.genkeys from PkgTemplates?

@gdalle
Copy link
Collaborator Author

gdalle commented Feb 9, 2024

It would have to be printed at the very end though cause there's lots of output. But it's a good idea, maybe open an issue to keep track?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Documenter key
3 participants