Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding testing command #5

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Allow overriding testing command #5

merged 1 commit into from
Jun 16, 2021

Conversation

staticfloat
Copy link
Member

This makes it easier for people who want all the instantiation goodness but want to override with their own testing command.

@staticfloat
Allow overriding testing command
a2455d0 
This now runs the `commands` block defined in the YAML pipeline, and
allows disabling of the default testing command by setting `run_tests`
to `false`.
@staticfloat staticfloat requested a review from maleadt June 14, 2021 20:55
@maleadt
Copy link
Member

maleadt commented Jun 15, 2021

How does BUILDKITE_COMMAND work in combination with this? Doesn't a command block override this plugin's command step?

@staticfloat
Copy link
Member Author

If a plugin has a command hook, it overrides buildkite's default "hook" of executing BUILDKITE_COMMAND. With this, julia-test will execute BUILDKITE_COMMAND in its command hook if it exists.

@maleadt
Copy link
Member

maleadt commented Jun 15, 2021

Ah that's handy, I thought the plugin overrode it destructively.

@staticfloat staticfloat merged commit 7805f8e into main Jun 16, 2021
@staticfloat staticfloat deleted the sf/run_tests branch June 16, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfloat @maleadt