RestXML PUT Requests Failing

[mattBrzezinski]

High-level S3 put_bucket_versioning is currently broken.

AWS.jl/src/services/s3.jl

Lines 1396 to 1397 in 9255fd4

	put_bucket_versioning(Bucket, VersioningConfiguration; aws_config::AWSConfig=global_aws_config()) = s3("PUT", "/$(Bucket)?versioning", Dict{String, Any}("VersioningConfiguration"=>VersioningConfiguration); aws_config=aws_config)
	put_bucket_versioning(Bucket, VersioningConfiguration, args::AbstractDict{String, <:Any}; aws_config::AWSConfig=global_aws_config()) = s3("PUT", "/$(Bucket)?versioning", Dict{String, Any}(mergewith(_merge, Dict{String, Any}("VersioningConfiguration"=>VersioningConfiguration), args)); aws_config=aws_config)

We are passing the VersionConfiguration as an argument named itself. However, this needs to be actually passed in as the body:

Current:

using AWS.AWSServices: s3
bucket = "test-bucket"
versioning_config = """
        <VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
            <Status>Enabled</Status>
        </VersioningConfiguration>
"""

s3("PUT", "/$(bucket)?versioning", Dict("VersioningConfiguration"=>versioning_config))

> ERROR: AWS.AWSExceptions.AWSException("MissingRequestBodyError", "Request Body is empty",

What we want:

using AWS.AWSServices: s3
bucket = "test-bucket"
versioning_config = """
        <VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
            <Status>Enabled</Status>
        </VersioningConfiguration>
"""

s3("PUT", "/$(bucket)?versioning", Dict("body"=>versioning_config))

---

Looks like putting tags for a bucket is in a similar situation:

AWS.jl/src/services/s3.jl

Lines 1378 to 1379 in 9255fd4

	put_bucket_tagging(Bucket, Tagging; aws_config::AWSConfig=global_aws_config()) = s3("PUT", "/$(Bucket)?tagging", Dict{String, Any}("Tagging"=>Tagging); aws_config=aws_config)
	put_bucket_tagging(Bucket, Tagging, args::AbstractDict{String, <:Any}; aws_config::AWSConfig=global_aws_config()) = s3("PUT", "/$(Bucket)?tagging", Dict{String, Any}(mergewith(_merge, Dict{String, Any}("Tagging"=>Tagging), args)); aws_config=aws_config)

Failing:

s3("PUT", "/$(bucket)?tagging", Dict("Tagging"=>tags); aws_config=aws, kwargs...)

Succeeding:

s3("PUT", "/$(bucket)?tagging", Dict("body"=>tags); aws_config=aws, kwargs...)

[mattBrzezinski]

Looking at the aws-sdk-js for the PutBucketVersioningRequest there is no obvious clues that these should be in the body.

"PutBucketVersioningRequest": {
      "type": "structure",
      "required": [
        "Bucket",
        "VersioningConfiguration"
      ],
      "members": {
        "Bucket": {
          "shape": "BucketName",
          "documentation": "<p>The bucket name.</p>",
          "location": "uri",
          "locationName": "Bucket"
        },
        "ContentMD5": {
          "shape": "ContentMD5",
          "documentation": "<p>&gt;The base64-encoded 128-bit MD5 digest of the data. You must use this header as a message integrity check to verify that the request body was not corrupted in transit. For more information, see <a href=\"http://www.ietf.org/rfc/rfc1864.txt\">RFC 1864</a>.</p>",
          "deprecated": true,
          "deprecatedMessage": "Content-MD5 header will now be automatically computed and injected in associated operation's Http request.",
          "location": "header",
          "locationName": "Content-MD5"
        },
        "MFA": {
          "shape": "MFA",
          "documentation": "<p>The concatenation of the authentication device's serial number, a space, and the value that is displayed on your authentication device.</p>",
          "location": "header",
          "locationName": "x-amz-mfa"
        },
        "VersioningConfiguration": {
          "shape": "VersioningConfiguration",
          "documentation": "<p>Container for setting the versioning state.</p>",
          "locationName": "VersioningConfiguration",
          "xmlNamespace": {
            "uri": "http://s3.amazonaws.com/doc/2006-03-01/"
          }
        },