S3: really call version 2 in list_objects_v2
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make laborg a reviewer |
|
bors try |
Co-authored-by: mattBrzezinski <matt.brzezinski@invenia.ca>
Co-authored-by: mattBrzezinski <matt.brzezinski@invenia.ca>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 17, 2021
317: S3: really call version 2 in `list_objects_v2` r=mattBrzezinski a=laborg Fixes #316 by only using S3 escape rules for the path. - With this I can properly use the continuation token for paginated results. - I don't know enough about minio to know if the added tests are suitable to detect a regression. - URIs.jl has been added as an dependency, but I feel that this will sooner or later be the case anyway. Co-authored-by: Gerhard Aigner <gerhard.aigner@gmail.com>
|
Thanks for steering this PR. I really like your work on AWS.jl. |
mattBrzezinski
approved these changes
Mar 17, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316 by only using S3 escape rules for the path.