-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFA integration tests for assume_role
#639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
commented
Jun 26, 2023
@@ -0,0 +1,193 @@ | |||
#!/usr/bin/env julia --project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a separate project/manifest isn't strictly necessary but avoids situations where you try to bootstrap the AWS resource setup with an in development version of AWS.jl which may could be broken.
mattBrzezinski
approved these changes
Jun 26, 2023
omus
commented
Jun 27, 2023
Co-authored-by: mattBrzezinski <3.brzezinski@gmail.com>
As this doesn't actually need a version bump I'll remove that and merge this |
omus
commented
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #638. Adds an IAM user with MFA devices such that we can validate the
mfa_serial
andtoken
keywords provided byassume_role
. In order to get this to work we needed to add the following:totp.jl
)The design of our MFA device setup is documented in the
setup.jl
file. The TLDR is by using multiple pre-setup MFA devices we can avoid having to wait or perform synchronization between multiple running tests using the AWS resources.