Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMDS.get returns nothing with HTTP 404 #653

Merged
merged 3 commits into from
Jul 28, 2023
Merged

IMDS.get returns nothing with HTTP 404 #653

merged 3 commits into from
Jul 28, 2023

Conversation

omus
Copy link
Member

@omus omus commented Jul 28, 2023 •
edited
Loading

Fixes: #652. As https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-retrieval.html#instance-metadata-returns mentions that the IMDS service may return 404 when specific resources are unavailable it made sense to return nothing under that scenario for IMDS.get.

@omus omus self-assigned this Jul 28, 2023
@omus omus requested a review from mattBrzezinski July 28, 2023 15:53
@omus omus merged commit bbe0f63 into master Jul 28, 2023
5 checks passed
@omus omus deleted the cv/imds-404 branch July 28, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees

@omus omus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role info isnt available via the IMDS service
2 participants
@omus @mattBrzezinski