Fallback to IMDSv1 when IMDSv2 token request reaches hop limit #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654, mitigates #651, and modifies PR #650 to no longer report the
ETIMEOUTas a connection error. It turns out that particular error indicates that the IMDSv2 PUT request for a token has reached the max hop limit and the server is rejecting the packet. This PR updates the IMDS code to classify this error as a TTL expiration and fall back to using IMDSv1 rather than treating the IMDS service as being unavailable.The TTL timeout is rather slow so users should consider increasing their hop limit in order to allow IMDSv2 to be used in these scenarios. I'll add a warning to inform users of this