Return both body and header for all AWS requests

[mattBrzezinski]

AWSS3.jl is having issues where the multi-part upload is not working properly, it attempts to return request headers back as both the part number and etag are required to successfully complete a multi-part upload.

AWSCore.jl currently does not return headers unless the operation is a HEAD type request. This merge request returns back the response body and headers for all requests, which accommodates for these requirements.

This change will allow use to begin resolving AWSS3.jl #84.

[mattBrzezinski]

bors try

[bors]

try

Build succeeded:

• continuous-integration/travis-ci/push

[Keno]

Good to go?

[mattBrzezinski]

@omus any thoughts?

He's on vacation.

[iamed2]

We can avoid a breaking change here.

Instead, we could have an inner method that returns both, and have do_request keep the same interface. This will prevent the pain of updating requirements everywhere.

[mattBrzezinski]

We can avoid a breaking change here.

Instead, we could have an inner method that returns both, and have do_request keep the same interface. This will prevent the pain of updating requirements everywhere.

Maybe it's too early in the morning, but I'm not following how this wouldn't be a breaking change. At some point we need the functionality to return back the headers and not just the response body.

[iamed2]

A slight tweak on my original idea:

Add a boolean headers argument to do_request, defaulting to false. If true, return the headers with the body, else keep the original interface.

Then this isn't a breaking change, and only the places that need to use the headers need to change.

[mattBrzezinski]

bors try

[bors]

try

Build succeeded:

• continuous-integration/travis-ci/push

[mattBrzezinski]

bors r+

[bors]

Build succeeded:

• continuous-integration/travis-ci/push

[Keno]

Why nothing here? This is the codepath I'm seeing AWSS3 take with your changes, resulting in:

MethodError: no method matching getindex(::Nothing, ::String)
Stacktrace:
 [1] s3_upload_part(::Dict{Symbol,Any}, ::XMLDict.XMLDictElement, ::Int64, ::Array{UInt8,1}) at /home/keno/.julia/dev/AWSS3/src/AWSS3.jl:698

[mattBrzezinski]

Fixed in #117 , I think the comment above it threw me off.