-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set FilePathsBase compatibility to 0.9.11 - 0.9.15 #232
Conversation
bors try |
I've managed to trigger bors today with a |
bors p=1 |
bors try |
tryAlready running a review |
if we want to take this approach, we will also need to edit the registry and add this cap to all previous versions of AWSS3 since |
I'm good for doing that as those versions are broken with FilePathsBase 0.9.16 |
bors try- |
bors try |
bors dashboard doesn't show trys unfortunately. The priority setting didn't seem to help but doing |
tryBuild failed: |
I seem to have set the upper bound to the wrong version |
bors try |
tryBuild succeeded: |
I'll merge this in the morning and get a few of the previously stuck PRs merged |
bors r+ |
232: Set FilePathsBase compatibility to 0.9.11 - 0.9.15 r=omus a=omus Fixes #227 by avoiding using FilePathsBase versions that require `readdir` when using `join=true` to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16 At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound. Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4 Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Build failed: |
Hmm, looks like there is more investigation to do here. I'll try a re-run to validate the error is reproducible |
bors try |
tryBuild succeeded: |
Interesting. Let's try merging again: bors r+ |
232: Set FilePathsBase compatibility to 0.9.11 - 0.9.15 r=omus a=omus Fixes #227 by avoiding using FilePathsBase versions that require `readdir` when using `join=true` to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16 At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound. Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4 Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
2/3 jobs have finished but the macOS job seems to have stalled. I'll wait a little longer but I'll manually merge this if we see another failure. This change is quite simple and the failure are unrelated. |
bors r- |
Canceled. |
Fixes #227 by avoiding using FilePathsBase versions that require
readdir
when usingjoin=true
to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound.
Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4