Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FilePathsBase compatibility to 0.9.11 - 0.9.15 #232

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

omus
Copy link
Member

@omus omus commented Feb 3, 2022

Fixes #227 by avoiding using FilePathsBase versions that require readdir when using join=true to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16

At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound.

Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors try

@omus omus requested a review from ericphanson February 3, 2022 21:53
@omus
Copy link
Member Author

omus commented Feb 3, 2022

I've managed to trigger bors today with a bors r+ but not with bors try. I'll do some experimentation here

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors p=1

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors try

@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

try

Already running a review

@ericphanson
Copy link
Member

if we want to take this approach, we will also need to edit the registry and add this cap to all previous versions of AWSS3 since readdir( ;join) was introduced, otherwise the resolver will just give you e.g. AWSS3 v0.9.2 + FilePathsBase v0.9.16

@omus
Copy link
Member Author

omus commented Feb 3, 2022

if we want to take this approach, we will also need to edit the registry and add this cap to all previous versions of AWSS3 since readdir( ;join) was introduced, otherwise the resolver will just give you e.g. AWSS3 v0.9.2 + FilePathsBase v0.9.16

I'm good for doing that as those versions are broken with FilePathsBase 0.9.16

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors try-

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors try

bors bot added a commit that referenced this pull request Feb 3, 2022
@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors dashboard doesn't show trys unfortunately. The priority setting didn't seem to help but doing git push origin :trying and then running bors try did.

@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

try

Build failed:

@omus
Copy link
Member Author

omus commented Feb 3, 2022

I seem to have set the upper bound to the wrong version

@omus
Copy link
Member Author

omus commented Feb 3, 2022

bors try

bors bot added a commit that referenced this pull request Feb 3, 2022
@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

try

Build succeeded:

@omus
Copy link
Member Author

omus commented Feb 4, 2022

I'll merge this in the morning and get a few of the previously stuck PRs merged

@omus
Copy link
Member Author

omus commented Feb 4, 2022

bors r+

bors bot added a commit that referenced this pull request Feb 4, 2022
232: Set FilePathsBase compatibility to 0.9.11 - 0.9.15 r=omus a=omus

Fixes #227 by avoiding using FilePathsBase versions that require `readdir` when using `join=true` to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16

At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound.

Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

Build failed:

@omus
Copy link
Member Author

omus commented Feb 4, 2022

Hmm, looks like there is more investigation to do here. I'll try a re-run to validate the error is reproducible

@omus
Copy link
Member Author

omus commented Feb 4, 2022

bors try

bors bot added a commit that referenced this pull request Feb 4, 2022
@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

@omus
Copy link
Member Author

omus commented Feb 4, 2022

Interesting. Let's try merging again:

bors r+

bors bot added a commit that referenced this pull request Feb 4, 2022
232: Set FilePathsBase compatibility to 0.9.11 - 0.9.15 r=omus a=omus

Fixes #227 by avoiding using FilePathsBase versions that require `readdir` when using `join=true` to return strings. As changing the return type could be breaking for some users we'll just limit the versions of FilePathsBase supported here for now for this release. For AWSS3.jl version 0.10 we'll correct that problem in this package and start using a minimum version of FilePathsBase 0.9.16

At first glance appears to address #226 but it does not as we are just temporarily setting an upperbound.

Also, we cannot use Pkg version ranges using a hypen as that requires a minimum version of Julia 1.4

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@omus
Copy link
Member Author

omus commented Feb 4, 2022

2/3 jobs have finished but the macOS job seems to have stalled. I'll wait a little longer but I'll manually merge this if we see another failure. This change is quite simple and the failure are unrelated.

@omus
Copy link
Member Author

omus commented Feb 4, 2022

bors r-

@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

Canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test failure: MethodError: no method matching parse(::Type{S3Path{Nothing}}, ::S3Path{Nothing})
2 participants