DataStructures 0.10.0 is not available yet

JuliaCloud · Jul 19, 2018 · b903553 · b903553
1 parent 24b1603
commit b903553
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/REQUIRE b/REQUIRE
@@ -1,5 +1,5 @@
 julia 0.7-DEV.1393
 Compat 0.60.0
 EzXML
-DataStructures 0.10.0
+DataStructures
 IterTools
diff --git a/src/XMLDict.jl b/src/XMLDict.jl
@@ -252,8 +252,11 @@ function dict_xml(root::AbstractDict)
     string("<?xml", attr_xml(root), "?>\n", node_xml(root))
 end
 
-attrs(node::AbstractDict) = filter(pair->isa(first(pair), Symbol), node)
-nodes(node::AbstractDict) = filter(pair->!isa(first(pair), Symbol), node)
+# FIXME: We can go back to using filter instead of filter! once
+# https://github.com/JuliaCollections/DataStructures.jl/issues/400 is fixed.
+# Calling filter! with copy is equivalent but inefficient.
+attrs(node::AbstractDict) = filter!(pair->isa(first(pair), Symbol), copy(node))
+nodes(node::AbstractDict) = filter!(pair->!isa(first(pair), Symbol), copy(n
 
 function attr_xml(node::AbstractDict)
     join([" $n=\"$v\"" for (n,v) in attrs(node)])