Improvements of Trie Structure #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Sep 11, 2021
| end | ||
| end | ||
|
|
||
| partial_path(t::Trie, str::AbstractString) = TrieIterator(t, str) | ||
| Base.IteratorSize(::Type{TrieIterator}) = Base.SizeUnknown() | ||
|
|
||
| function find_prefixes(t::Trie, str::AbstractString) |
There was a problem hiding this comment.
added in the latest commit
oxinabox
reviewed
Sep 11, 2021
docs/src/trie.md
Outdated
|
|
||
| ```julia | ||
| t = Trie(["A", "ABC", "ABCD", "BCE"]) | ||
| find_prefixes(t, "ABCDE") # "A", "ABC" |
There was a problem hiding this comment.
why does this not return ABCD as well?
There was a problem hiding this comment.
That's my mistake. I fixed it.
|
Thanks. Note that we are currently feature frozen pending #479 The fix TrieIterator to correctly handle non-ascii characters change is a good bug fix, which we can backpoint to the 0.18.x line. |
|
Thank you for your comment. I updated my commits according to your suggestion. |
oxinabox
approved these changes
Sep 12, 2021
ReubenJ
added a commit
to ReubenJ/DataStructures.jl
that referenced
this pull request
Jul 8, 2024
Squashed version of commits in JuliaCollections#756 with relevant changes only. Backport to v0.18, meaning we're not including `find_prefixes`. Co-authored-by: Du Shiqiao <lucidfrontier.45@gmail.com> Co-authored-by: Reuben Gardos Reid <5456207+ReubenJ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improved
Triewith the following two points.TrieIteratorto correctly handle non-ascii charactersfind_prefixesfunction which is equivalent toprefixesmethod of https://github.com/pytries/marisa-trie