add AMQPS support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds AMQPS (TLS) connections support.
The IANA assigned port number for AMQPS is 5671. It is available as the constant `AMQPClient.AMQPS_DEFAULT_PORT`.
An example of making an AMQPS connection:
```julia
conn = connection(; virtualhost="/",
host = "amqps.example.com",
port = AMQPFlient.AMQPS_DEFAULT_PORT
auth_params = Dict{String,Any}("MECHANISM"=>"AMQPLAIN", "LOGIN"=>"guest", "PASSWORD"=>"guest"),
amqps = amqps_configure()
)
```
The `amqps_configure` method can be provided additional parameters for TLS connections:
- cacerts: A CA certificate file (or it's contents) to use for certificate verification.
- verify: Whether to verify server certificate. Default is false if cacerts is not provided and true if it is.
- client_cert and client_key: The client certificate and corresponding private key to use. Default is nothing (no client certificate). Values can either be the file name or certificate/key contents.
```julia
amqps_configure(;
cacerts = nothing,
verify = MbedTLS.MBEDTLS_SSL_VERIFY_NONE,
client_cert = nothing,
client_key = nothing
)
```
|
Coverage decreased because CI does not cover AMQPS mode yet. |
|
I think you should have a default parameter Line 541 in d057d0b Otherwise you will get this error when not explicitly specifying the |
tanmaykm
added a commit
that referenced
this pull request
Feb 15, 2021
This fixes issue where the keyword parameter `amqps` was missing a value in `connection` method. Ref: #32 (comment)
|
Yes indeed. Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AMQPS (TLS) connections support.
The IANA assigned port number for AMQPS is 5671. It is available as the constant
AMQPClient.AMQPS_DEFAULT_PORT.An example of making an AMQPS connection:
The
amqps_configuremethod can be provided additional parameters for TLS connections:fixes: #19