allow using tcp keepalives instead of heartbeats #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMQP allows heartbeats to be disabled completely, provided the server allows that.
But it is essential to have an alternative to detect network disconnections and stale
connections. In this PR, we switch on TCP keepalives on the connection (optional but
enabled by default) and allow heartbeats to be switched off. Heartbeats are still
enabled by default though.
The `connection` method has these new parameters to allow that:
```julia
connection(;
heartbeat = true,
keepalive = DEFAULT_KEEPALIVE_SECS,
)
```
- `heartbeat`: `true` to enable heartbeat, `false` to disable. Can also be set to a positive integer,
in which case it is the heartbeat interval in seconds. Defaults to `true`. If `false`, ensure
`keepalive` is enabled to detect dead connections. This parameter is negotiated with the server.
- `keepalive`: `true` to enable TCP keepalives, `false` to disable. Can also be set to a positive integer,
in which case it is the keepalive interval in seconds. Defaults to `DEFAULT_KEEPALIVE_SECS`.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 82.18% 82.02% -0.17%
==========================================
Files 9 9
Lines 1016 1029 +13
==========================================
+ Hits 835 844 +9
- Misses 181 185 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMQP allows heartbeats to be disabled completely, provided the server allows that.
But it is essential to have an alternative to detect network disconnections and stale
connections. In this PR, we switch on TCP keepalives on the connection (optional but
enabled by default) and allow heartbeats to be switched off. Heartbeats are still
enabled by default though.
The
connectionmethod has these new parameters to allow that:heartbeat:trueto enable heartbeat,falseto disable. Can also be set to a positive integer,in which case it is the heartbeat interval in seconds. Defaults to
true. Iffalse, ensurekeepaliveis enabled to detect dead connections. This parameter is negotiated with the server.keepalive:trueto enable TCP keepalives,falseto disable. Can also be set to a positive integer,in which case it is the keepalive interval in seconds. Defaults to
DEFAULT_KEEPALIVE_SECS.