Return conn instead of chan from connection fun

[mfalt]

Might break some code that depends on this incorrect behavior.

[tanmaykm]

Thanks, this does seem correct.
Just want to walk through the code once to check if anything else is impacted before merging.

[nsslh]

I am anxious about the impact of this change on existing code that passes the return value of connection into channel.

conn = connection(; ...)
chan = channel(conn, AMQPClient.UNUSED_CHANNEL, true)
basic_qos(chan, 0, 1, false; timeout = 10)
success, queue_name, ... = queue_declare(...)
... = basic_consume(chan, queue_name, msg -> consume_fn(chan, msg, routes))
fetch(chan.consumers[consumer_tag].receiver)

[mfalt]

I think this specific case won't be a problem since the channel function seems to have been implemented to handle both connection and `channel``as input:

AMQPClient.jl/src/protocol.jl

Line 537 in 3f00456

channel(c::MessageChannel, id::Integer) = channel(c.conn, id)

It would however break code like this:

conn = connection(; ...)
chan = channel(chan.conn, AMQPClient.UNUSED_CHANNEL, true)

So I think it warrants a bump to 0.5

[nsslh]

So I think it warrants a bump to 0.5

If AMQPClient is using semantic versioning, then 1.0.0 is probably a safer choice, since it's a breaking change (for some).

[mfalt]

Semver doesn't require any compability for releases before 1.0.0, but Julia specifies that the minor version should be updated for breaking changes pre 1.0 https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0

…

On Mon, Aug 15, 2022, 11:11 nsslh ***@***.***> wrote: So I think it warrants a bump to 0.5 If AMQPClient is using semantic versioning, then 1.0.0 is probably a safer choice, since it's a breaking change (for some). — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYWKSNKBWXR4AI32WK3LSLVZICTXANCNFSM5SI3SERQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[nsslh]

Semver doesn't require any compability for releases before 1.0.0

I had never noticed that. Thanks!

[nsslh]

Fixes #51