[WIP] Implement rewrite validator #55
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not to confuse it with the nonlocal insertion
|
@Keno does the code in |
serenity4
commented
Jun 20, 2025
| sciml_prob = DiffEqBase.get_concrete_problem(our_prob, true); | ||
| f_compressed = sciml_prob.f.f | ||
| f_compressed(residuals_compressed, du_compressed, u_compressed, p, t) | ||
| # XXX: `ddt(x₁)` gets substituted by `x₁ *ᵢ x₂` for the last equation after scheduling. |
There was a problem hiding this comment.
I briefly mentioned it in our last call, but I'm not sure I understand how we should work around that assuming that the overall approach is correct. Codegen looks at the past du for the first equation but then looks at its expected value (i.e. its RHS) for the last equation, even though we are using ddt(x1) in both expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47.
This PR is based on #54, for a clean view of the changes see the comparison against that PR.
This is still largely a work in progress, I am just putting it here for discussion.