-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Recommendation.jl: A Framework for Building Recommender Systems in Julia #147
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper source files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for 🔴 Failed to discover a |
License info: ✅ License found: |
|
@PGimenez, @abhijithch, thank you very much for volunteering as reviewers! I will be the editor for this submission, feel free to ping me to ask any questions you may have. You can find review guidelines here feel free to ask at any point if something is unclear. As a first step, you can generate your checklist by running
You can write your review comments here or directly open an issue in the paper repository |
@editorialbot remove @lucaferranti as reviewer |
@lucaferranti removed from the reviewers list! |
Hi @abhijithch and @PGimenez 👋 , just checking in to see if you had time to start the review. Any timeline estimate? |
Review checklist for @PGimenezConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
Content
|
Hi, I'd like to submit my review of the paper "Recommendation.jl: A Framework for Building Recommender Systems in Julia" below. I believe this is a good paper on recommender systems. It does a deep enough review on the most popular methods used in the literature, and provides implementation details in the package. The paper is well-written, with clear language and good usage of math notation to explain concepts. I think the pape is apt for publication with minor changes/corrections. There are a few minor points I'd like to raise, which can also be found in the attached annotated PDF:
Or leave as it is and add "be" before each variable like
Then, a few more points: The cold-start problem In 3.4 you state that the cold-start problem arises when "there is not enough historical data to capture meaningful information". The question then is, how much data is needed? I believe a single rating is enough. To me, the issue here is adding new users or items to the system since these haven't rated or haven't been rated by anyone yet. Therefore the system cannot find items similar to the one the user likes (which is none since they've rated nothing) From a formulation standpoint, new users and items have an empty row/column in matrix R. When factorizing R with any of the earlier methods, the coefficients associated with the new user/item (p_i, q_j for instance) will be all-zero. This would yield no recommendations. This can be solved by leveraging additional information in the form of feature vectors (the user This usage of attribute vectors can be incorporated into the matrix factorization technique as well, as shown in these papers Towards Open-World Recommendation: An Inductive Model-based Collaborative Filtering Approach My point here is: If most of the implemented algorithms can't solve the cold-start problem, how usable are they in real-world situations? Experimental results The results are good for showcasing the different implemented metrics and having a better understanding of their meaning. However, I find it lacking that only the SVD method is used. I'd expect the experiments to also show how this package allows to easily switch between algorithms. Also, some benchmarks as to their computational cost. Package documentation The package documentation is good, as it covers the algorithms in detail. It'd be good to also have one or two tutorials like the script included in the paper. (I there are already, sorry, I couldn't find any) |
sorry, forgot to attach the annotated PDf =) |
Thank you for the review comments, @PGimenez! Just informing you that I am actively working on the points and hopefully update you in the coming weeks. cc: @lucaferranti |
Hi @abhijithch 👋 , how is it going with the review? Do you happen to have an estimated timeline? |
Hi everyone 👋 , just checking in to see how this review is going. @takuti did you manage to address the comments raised by @PGimenez . @abhijithch how is it going with the review? Any expected timeline? |
@editorialbot assign @lucaferranti as editor |
Assigned! @lucaferranti is now the editor |
@lucaferranti Thank you for checking in and sorry for the late reply. I'm a bit occupied lately but making slow progress on addressing the review comments. I probably want to wait until I receive the second reviewer's comments so I can efficiently address all of them in a batch. |
Thanks @takuti, yes waiting for the second reviewer is reasonable. @abhijithch do you have any updates on your review? If you are unable to complete the review, please let me know so that I can find another one |
@lucaferranti, apologies for not replying sooner. I will work on this and will share the review comments soon. |
Submitting author: @takuti (Takuya Kitazawa)
Repository: https://github.com/takuti/Recommendation.jl
Branch with paper.md (empty if default branch):
Version:
Editor: @lucaferranti
Reviewers: @abhijithch, @PGimenez
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lucaferranti & @abhijithch & @PGimenez, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucaferranti know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @PGimenez
The text was updated successfully, but these errors were encountered: