Fix sort with unused levels #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code did not handle correctly the case when unused levels were present at the front. This seems to have become easier to trigger since the index vs. levels distinction was dropped.
bkamins
reviewed
May 19, 2020
src/array.jl
Outdated
| perm = sortperm(view(index, seen), order=ord) | ||
| nzcounts = counts[seen] | ||
| levs = eltype(v) >: Missing ? [missing; v.pool.valindex] : v.pool.valindex | ||
| sortedlevs = sort(Vector(view(levs, seen)), order=ord) |
There was a problem hiding this comment.
why not use? sort!(levs[seen], order=ord)
There was a problem hiding this comment.
We need a Vector to avoid calling ourselves and getting a stack overflow. But yes sort! should work.
There was a problem hiding this comment.
levs[seen] would create a new vector anyway - right? But this is minor I guess so it can stay as is.
There was a problem hiding this comment.
Actually there's a weird behavior which creates a CategoricalVector with logical indexing. Need to investigate that...
There was a problem hiding this comment.
This is so tricky that I ended up filing a design issue against Base: JuliaLang/julia#36106.
bkamins
reviewed
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code did not handle correctly the case when unused levels were present at the front.
This seems to have become easier to trigger since the index vs. levels distinction was dropped.
Fixes #269.