Loosen constructor for a DataFrame (#1108)

JuliaData · Jul 8, 2017 · 694ebfe · 694ebfe
1 parent 851e7c4
commit 694ebfe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/dataframe/dataframe.jl b/src/dataframe/dataframe.jl
@@ -102,9 +102,9 @@ function DataFrame(; kwargs...)
     return result
 end
 
-function DataFrame(columns::Vector{Any},
-                   cnames::Vector{Symbol} = gennames(length(columns)))
-    return DataFrame(columns, Index(cnames))
+function DataFrame(columns::AbstractVector,
+                   cnames::AbstractVector{Symbol} = gennames(length(columns)))
+    return DataFrame(convert(Vector{Any}, columns), Index(convert(Vector{Symbol}, cnames)))
 end
 
 

diff --git a/test/dataframe.jl b/test/dataframe.jl
@@ -185,6 +185,7 @@ module TestDataFrame
     @test typeof(df[:,:a]) == NullableVector{Int}
     @test typeof(df[:,:b]) == NullableVector{Char}
 
+    @test DataFrame(NullableArray[[1,2,3],[2.5,4.5,6.5]], [:A, :B]) == DataFrame(A = [1,2,3], B = [2.5,4.5,6.5])
 
     # This assignment was missing before
     df = DataFrame(Column = [:A])