Rename groupby to group_by

[GlenHertz]

Hi,

This is to discuss changing groupby to group_by so that it is consistent with sort_by. I found myself typing the wrong names when switching between the two.

Glen

[johnmyleswhite]

How about going the other way and renaming sort_by to sortby?

[tshort]

+1 for groupby and sortby.
On Dec 28, 2012 5:18 PM, "John Myles White" notifications@github.com
wrote:

How about going the other way and renaming sort_by to sortby?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/139#issuecomment-11743035.

[StefanKarpinski]

I can get behind that. I'll propose it on the Julia side and see how that goes over.

[GlenHertz]

I like it.

[johnmyleswhite]

Closed by 54f5431

I renamed sort_by in DataFrames now. We can bikeshed Base Julia later.

[johnmyleswhite]

We should check that this is completely fixed, since Julia is no longer providing a sortby that we could conflict with.

[StefanKarpinski]

The fact that DataFrames is providing a sortby makes me wonder if sortby(f,v) shouldn't be a shorthand for the new sort(Sort.By(f),v). Perhaps that and sort(f,v) as short for sort(Sort.Lt(f),v). I was trying to get the interface minimal before, but those two additions seem pretty reasonable.

[johnmyleswhite]

I don't understand the new sorting functions yet, but sort(f, d) sounds like it applies f and then sorts. DataFrames does sortby(column, dataframe), which feels quite distinct. I wouldn't burden Base with another name that does something else.