Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Base.vcat AbstractDataFrame should rely on Base.vcat for columns #1118

Closed
wants to merge 79 commits into from

Commits on Sep 14, 2016

  1. RFC: Add compatibility with pre-contrasts ModelFrame constructor (Jul…

    …iaData#1042)
    
    Add compatibility with pre-contrasts ModelFrame constructor
    Gord Stephen authored and nalimilan committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    968e980 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Reindex transposed sparse contrast matrix into modelmat_cols column-w…

    …ise for speed improvement (JuliaData#1070)
    Gord Stephen authored and nalimilan committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    d4ad15b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2016

  1. Configuration menu
    Copy the full SHA
    2931693 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2016

  1. Port to NullableArrays and CategoricalArrays

    Completely remove support for DataArrays.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    e4662fd View commit details
    Browse the repository at this point in the history
  2. Get rid of custom Nullable operators and functions

    This depends on PRs moving these into NullableArrays.jl.
    Also use isequal() instead of ==, as the latter is in Base and
    unlikely to change its semantics.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    9de5c08 View commit details
    Browse the repository at this point in the history
  3. Fix grouping

    groupby() did not follow the order of levels, and wasn't robust to reordering
    levels. Add tests for corner cases.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    6ac7549 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    653fc1d View commit details
    Browse the repository at this point in the history
  5. Remove optimized sorting methods

    Use the fallbacks for now, should be added back after
    JuliaData/CategoricalArrays.jl#12 is fixed.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    a17f264 View commit details
    Browse the repository at this point in the history
  6. Remove inscrutable FIXME

    Not sure what I meant by this. If it was really serious, we'll discover
    it sooner or later.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    9a71705 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9f1e5e6 View commit details
    Browse the repository at this point in the history
  8. Remove another FIXME

    This is a much more general issue (JuliaStats/NullableArrays.jl#85) which
    can be tackled later.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    a75a4a4 View commit details
    Browse the repository at this point in the history
  9. Remove FIXME about insert!()

    For now, preserve the current semantics: conversion to NullableArray
    does not happen via insert!().
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    1b44ffe View commit details
    Browse the repository at this point in the history
  10. Remove FIXME about +(::NullableArray{Int}, ::Int)

    Again a broader issue which doesn't particularly affect DataFrames. Cf.
    JuliaStats/NullableArrays.jl#143
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    0ff4dc8 View commit details
    Browse the repository at this point in the history
  11. Remove FIXME about test/indexing.jl

    Better handle that separately.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    110deac View commit details
    Browse the repository at this point in the history
  12. Remove FIXME about map()

    Shorter written that way for now. Filed as JuliaStats/NullableArrays.jl#144.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    0ff6373 View commit details
    Browse the repository at this point in the history
  13. Fix sortperm() tests

    This depends on a CategoricalArrays change by which levels are sorted when
    creating the array.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    431d135 View commit details
    Browse the repository at this point in the history
  14. Remove FIXME about predict()

    There's no inconsistency here: when the input is a Matrix, there's no
    point in returning a NullableArray. Anyway, these are test methods.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    cc87f46 View commit details
    Browse the repository at this point in the history
  15. Remove FIXME about head() and tail()

    We don't have to handle this right now.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    ec9b706 View commit details
    Browse the repository at this point in the history
  16. Remove FIXME about PooledDataVecs

    Keep this in DataFrames for now, renaming it to the more explicit
    sharepools(). Also relax signatures to accept non-Nullable categorical arrays.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    e9a1c8c View commit details
    Browse the repository at this point in the history
  17. Remove unused NominalArray methods

    These were not exercized by the tests, and the use case for them isn't obvious.
    (They were formerly methods of DataArrays.PooledDataArray().)
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    bf16c5f View commit details
    Browse the repository at this point in the history
  18. Mention Julia bug in FIXME

    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    3bb1323 View commit details
    Browse the repository at this point in the history
  19. Bump dependencies on NullableArrays and CategoricalArrays

    For NullableArrays, even current git master is not enough at this time.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    95789bf View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5c33249 View commit details
    Browse the repository at this point in the history
  21. Bump CategoricalArrays requirement

    quinnj authored and nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    e1df391 View commit details
    Browse the repository at this point in the history
  22. Fix tests on Julia 0.4

    Tests pass, but the Nullable{Any} results could be annoying for users.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    63c1d96 View commit details
    Browse the repository at this point in the history
  23. Use CategoricalArray instead of NominalArray

    New type merging NominalArray and OrdinalArray in 0.0.5.
    nalimilan committed Sep 22, 2016
    2 Configuration menu
    Copy the full SHA
    2ec131e View commit details
    Browse the repository at this point in the history
  24. Remove DataArrays benchmarks

    These shouldn't live in DataFrames.
    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    ad75f67 View commit details
    Browse the repository at this point in the history
  25. Update docs

    nalimilan committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    492351c View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    d48d7f8 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    f8dc8c6 View commit details
    Browse the repository at this point in the history
  28. Cleanup a few more examples

    quinnj committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    fde1c96 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2016

  1. Configuration menu
    Copy the full SHA
    a2ae0ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eddb824 View commit details
    Browse the repository at this point in the history
  3. Remove reference to DataArray

    quinnj committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    c27e45a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f158285 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d082a8d View commit details
    Browse the repository at this point in the history
  6. Bump DataFrames to julia 0.5-

    quinnj committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    07c46d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2016

  1. Configuration menu
    Copy the full SHA
    ec0126d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f53aeaf View commit details
    Browse the repository at this point in the history
  3. Fix failing tests

    quinnj committed Sep 24, 2016
    Configuration menu
    Copy the full SHA
    854ce92 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    166475a View commit details
    Browse the repository at this point in the history
  5. Avoid introducing new loadiris() function

    The full code isn't that longer, and we can go back to the original code
    when RDataset will have been ported.
    nalimilan committed Sep 24, 2016
    Configuration menu
    Copy the full SHA
    044537f View commit details
    Browse the repository at this point in the history
  6. Make == fall back to isequal() for now

    Since we give them the same semantics for now, there's no point in keeping
    separate functions.
    nalimilan committed Sep 24, 2016
    Configuration menu
    Copy the full SHA
    1864086 View commit details
    Browse the repository at this point in the history
  7. Rename categorize() to categorical()

    More logical name for the constructor provided by CategoricalArray.
    categorical!() is the in-place equivalent provided only by DataFrames. Also
    move the compacting logic into CategoricalArrays, as it's both a cleaner
    design and a more efficient one.
    nalimilan committed Sep 24, 2016
    Configuration menu
    Copy the full SHA
    1fe210d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2016

  1. Fix failure in I/O test

    We can't rely on the exact contents of a NULL.
    nalimilan committed Sep 25, 2016
    Configuration menu
    Copy the full SHA
    333ce3e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2016

  1. Deprecate pool properly

    quinnj committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    698ba0f View commit details
    Browse the repository at this point in the history
  2. Merge pull request JuliaData#1008 from JuliaStats/nl/nullable

    Port to NullableArrays and CategoricalArrays
    quinnj authored Sep 26, 2016
    Configuration menu
    Copy the full SHA
    18fd664 View commit details
    Browse the repository at this point in the history
  3. Only sort duplicated columns once (JuliaData#1072)

    * Only sort duplicated columns once
    
    * Added comments
    
    * moved check for identical arrays inside of for loop
    
    * Don't mention PR under /src, only mention them under /test
    gustafsson authored and ararslan committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    6590ac1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2016

  1. collecting with brackets is deprecated (JuliaData#939)

    Resolve "WARNING: [a] concatenation is deprecated; use collect(a) instead"
    gustafsson authored and nalimilan committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    5998148 View commit details
    Browse the repository at this point in the history
  2. Fix test failures on master (JuliaData#1075)

    Use vcat() instead of collect() in colwise(), and identity() instead of abs(),
    since the latter do not work with Nullable.
    nalimilan authored Sep 27, 2016
    Configuration menu
    Copy the full SHA
    6c760d9 View commit details
    Browse the repository at this point in the history
  3. Update Documenter syntax (JuliaData#966)

    Also switch from mkdocs output to Documenter's HTML output.
    MichaelHatherly authored and nalimilan committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    115bb5e View commit details
    Browse the repository at this point in the history
  4. test empty frames joins

    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    576b26b View commit details
    Browse the repository at this point in the history
  5. test empty frames groupby()

    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    2b932f9 View commit details
    Browse the repository at this point in the history
  6. more DataFrame assignment tests

    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    bd3e2b2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c544b91 View commit details
    Browse the repository at this point in the history
  8. simplify eltypes()

    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    f21be25 View commit details
    Browse the repository at this point in the history
  9. small cleanups to stack/unstack

    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    d2245ef View commit details
    Browse the repository at this point in the history
  10. immutable GroupApplied, enhance combine()

    make GroupApplied immutable by adding subframe type parameter
    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    43e4393 View commit details
    Browse the repository at this point in the history
  11. aggregate() optimizations

    * avoid [:], use reshape()
    * avoid unnecessary Symbol<->String conversions
    alyst committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    06e71f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. fix groupby() doc

    alyst committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    da389d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2016

  1. Configuration menu
    Copy the full SHA
    de55a0e View commit details
    Browse the repository at this point in the history
  2. Merge pull request JuliaData#1076 from alyst/misc_fixes

    Misc minor enhancements
    ararslan authored Oct 1, 2016
    Configuration menu
    Copy the full SHA
    23ec690 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2016

  1. Configuration menu
    Copy the full SHA
    1658c35 View commit details
    Browse the repository at this point in the history
  2. handle A ~ B - 1 and add tests (JuliaData#1086)

    * handle -1 and add tests
    
    * replace `import Base.==` with `Base.:(==)`
    
    * typo and error test
    kleinschmidt authored and ararslan committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    400da84 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Fix join when mixing NullableArray and Array{Nullable} (JuliaData#1089)

    Also return a NullableCategoricalArray from sharepools() since
    the code currently doesn't check that no null values are present.
    anyway this function is internal and the change imposes no overhead.
    nalimilan authored Oct 4, 2016
    Configuration menu
    Copy the full SHA
    e1c5014 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. Better display of Nullables (JuliaData#1084)

    * Better display of Nullables
    
    * Don't write trailing space in Latex output
    
    Also fix missing newline in show test
    amellnik authored and nalimilan committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    725a226 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2016

  1. Configuration menu
    Copy the full SHA
    e4ab277 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. limit attribute of IOContext is used for html generation (JuliaData#1099

    )
    
    * limit attribute of IOContext is used for html generation
    
    * fixup
    jw3126 authored and ararslan committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    203b50f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2016

  1. Fix docstring example (JuliaData#1107)

    femtotrader authored and nalimilan committed Oct 16, 2016
    Configuration menu
    Copy the full SHA
    b6de65a View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2016

  1. Configuration menu
    Copy the full SHA
    10c4423 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cae226 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2016

  1. Configuration menu
    Copy the full SHA
    e7ea227 View commit details
    Browse the repository at this point in the history
  2. Small docs fixes (JuliaData#1077)

    I apparently missed these occurrences when removing these functions.
    nalimilan authored Oct 22, 2016
    Configuration menu
    Copy the full SHA
    3706704 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Enable doctests (JuliaData#1110)

    davidanthoff authored and nalimilan committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    e418174 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2016

  1. Configuration menu
    Copy the full SHA
    6b3bb5c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2016

  1. Use vcat to find column type but not for concatenation

    Johan Gustafsson committed Nov 7, 2016
    Configuration menu
    Copy the full SHA
    1a96917 View commit details
    Browse the repository at this point in the history
  2. spaces

    Johan Gustafsson committed Nov 7, 2016
    Configuration menu
    Copy the full SHA
    ce33c83 View commit details
    Browse the repository at this point in the history
  3. Use promote_eltype to find eltype

    Johan Gustafsson committed Nov 7, 2016
    Configuration menu
    Copy the full SHA
    f10ae4a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2016

  1. fixed review comments

    Johan Gustafsson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    4dcc24b View commit details
    Browse the repository at this point in the history