Clean up isless(::DataFrameRow, ::DataFrameRow) #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the code logic to match that used for Tuple and make it more natural. Fix tests changed by 6035da8, and which should not use < and == (even if the latter falls back to isless).
|
Fun fact: When I view a page in a language other than English, my browser automatically adds a spam filter for the language. When I viewed the diff here just a moment ago, my browser automatically added an Icelandic spam filter. 🤔 |
quinnj
approved these changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the code logic to match that used for Tuple and make it more natural.
Fix tests changed by 6035da8, and which should not use < and ==
(even if the latter falls back to isless).